-
Notifications
You must be signed in to change notification settings - Fork 95
fix(NcButton): re-export types #6871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Grigorii K. Shartsev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Affects much more components.
Either fix all manually or we deprecate using the main import in general and simply do not export types there so you only import
import type { ButtonVariant } from '@nextcloud/vue/components/NcButton'
This is the only component with type export |
@skjnldsv Does it work for you? |
I stopped using the type, cannot tell 🙈 |
converted to draft until we decided if this is the way we want it to be, ref: |
Reopen if we decide the other way around but otherwise lets keep types in component entry points |
☑️ Resolves
🏁 Checklist
stable8
for maintained Vue 2 version or not applicable