Skip to content

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 24, 2025

Backport of #7084

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from DorraJaouad, ShGKme and Antreesy June 24, 2025 11:47
@backportbot backportbot bot added 3. to review Waiting for reviews feature: modal Related to the modal component labels Jun 24, 2025
@backportbot backportbot bot added this to the 8.27.1 milestone Jun 24, 2025
@Antreesy Antreesy force-pushed the backport/7084/stable8 branch from 0531cb7 to ab12076 Compare June 24, 2025 13:19
@Antreesy
Copy link
Contributor

Maybe it's another issue 🤔

Steps:
Talk -> Mobile width -> Expand left sidebar -> Open 'New conversation' dialog

In Vue 3: image
there is only latest trap in the stack

In Vue 2: image
left sidebar trap is paused, but focus is still trapped there. so should remain deactivated as before

@susnux susnux modified the milestones: 8.27.1, 8.28.1, 8.29.0 Jul 15, 2025
@nfebe
Copy link
Contributor

nfebe commented Aug 9, 2025

Hello @Antreesy please what is the status of this? There is a bug where NcModal.clearFocusTrap() attempts to reactivate external focus traps no longer have valid DOM containers when cleaning up password dialogs spawned from NcActionInput contexts.

This can be seen in Nextcloud -> accounts -> create new group | rename group

After some spiraling from nextcloud/password-confirmation to nextcloud/dialogs it appears this is the fix which is still absent from the current stable used in nextcloud/server.

@Antreesy
Copy link
Contributor

As written above, same fix isn't working with Vue2
Current state will remove an error coming from password-confirmation library, but break all places with 2+ active focus traps

@susnux
Copy link
Contributor

susnux commented Aug 18, 2025

#7304

@susnux susnux closed this Aug 18, 2025
@susnux susnux deleted the backport/7084/stable8 branch August 18, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: modal Related to the modal component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants