Skip to content

feat: switch to outline icons - #1852

Merged
max-nextcloud merged 1 commit into
mainfrom
fix/outline-icons
Aug 18, 2025
Merged

feat: switch to outline icons#1852
max-nextcloud merged 1 commit into
mainfrom
fix/outline-icons

Conversation

@blizzz

@blizzz blizzz commented Jul 3, 2025

Copy link
Copy Markdown
Member

📝 Summary

No outlined variant is available for:

AccountMultiplePlus.vue
ArrowBottomLeft.vue
ArrowDown.vue
ArrowUp.vue
BackupRestore.vue
ChevronDown.vue
ChevronLeft.vue
ChevronRight.vue
CollectiveActions.vue
CollectivesTrash.vue
ContentCopy.vue
DockRight.vue
FileCompare.vue
FormatListBulleted.vue
Item.vue
Logout.vue
Magnify.vue
MemberPicker.vue
MembersWidget.vue
Navigation.vue
OpenInNew.vue
PageActionMenu.vue
PageFavorites.vue
PageList.vue
PagePicker.vue
PageSidebar.vue
PageTrash.vue
PageVersion.vue
Paperclip.vue
RecentPagesWidget.vue
Restore.vue
SearchDialog.vue
SharingEntryLink.vue
SidebarTabAttachments.vue
SidebarTabBacklinks.vue
SidebarTabVersions.vue
SortAlphabeticalAscending.vue
SortAlphabeticalDescending.vue
SortAscending.vue
TriangleSmallDown.vue
Version.vue

@blizzz blizzz added design enhancement New feature or request 3. to review labels Jul 3, 2025
@blizzz
blizzz requested a review from a team July 3, 2025 16:24
@max-nextcloud

This comment was marked as resolved.

@blizzz

blizzz commented Jul 18, 2025

Copy link
Copy Markdown
Member Author
  • I also need to add an exception for the checkmark and i think edit icon.
  • also reverted Close icon

@blizzz
blizzz force-pushed the fix/outline-icons branch 3 times, most recently from 5996591 to 05f328f Compare July 30, 2025 09:06
@blizzz

blizzz commented Jul 30, 2025

Copy link
Copy Markdown
Member Author

Expected to find element: span.sort-ascending-icon, but never found it.

Looks like the cypress tests also check for some of the icon classes and need to be adjusted.

Everything's settled!

@mejo-

mejo- commented Jul 30, 2025

Copy link
Copy Markdown
Member

Everything's settled!

Thanks a lot @blizzz! What do you think about waiting with the merge and release until Nextcloud 32 release? If we release this earlier, it will just confuse people with Nextcloud 30 + 31 UI, no? 🤔

I think it's an acceptable tradeoff to have the outline icons also in Collectives with Nextcloud 30 and 31 to not have to maintain a separate release branch, but I'd wait until the new layout with outline icons is actually used on production systems (i.e. RC release of stable32).

@blizzz

blizzz commented Jul 30, 2025

Copy link
Copy Markdown
Member Author

Everything's settled!

Thanks a lot @blizzz! What do you think about waiting with the merge and release until Nextcloud 32 release? If we release this earlier, it will just confuse people with Nextcloud 30 + 31 UI, no? 🤔

I think it's an acceptable tradeoff to have the outline icons also in Collectives with Nextcloud 30 and 31 to not have to maintain a separate release branch, but I'd wait until the new layout with outline icons is actually used on production systems (i.e. RC release of stable32).

I understand 32 stuff should be ready by Aug 19 with Beta 1 of 32 (base for screenshots). Is this OK?

@mejo-

mejo- commented Jul 31, 2025

Copy link
Copy Markdown
Member

I understand 32 stuff should be ready by Aug 19 with Beta 1 of 32 (base for screenshots). Is this OK?

Sure, sounds good to me.

@blizzz

blizzz commented Aug 15, 2025

Copy link
Copy Markdown
Member Author

@mejo- this should go in soon, but I am OOTO.

@max-nextcloud

Copy link
Copy Markdown
Collaborator

I rebased on current main and resolved the conflicts. Will enable auto merge and follow up in case that fails.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@mejo-
mejo- force-pushed the fix/outline-icons branch from a916150 to 10339d3 Compare August 17, 2025 18:50
@max-nextcloud
max-nextcloud merged commit a680a24 into main Aug 18, 2025
52 checks passed
@max-nextcloud
max-nextcloud deleted the fix/outline-icons branch August 18, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🎨 Use outline icons

3 participants