Skip to content

Fix master checks#2991

Merged
christianlupus merged 4 commits intomasterfrom
maintenance/fix-master-checks
Feb 9, 2026
Merged

Fix master checks#2991
christianlupus merged 4 commits intomasterfrom
maintenance/fix-master-checks

Conversation

@christianlupus
Copy link
Collaborator

@christianlupus christianlupus commented Feb 4, 2026

Topic and Scope

This should make sure the unit test are again running as intended also on the master branch of NC server.

Concerns/issues

This is a regression fixing that should have been part of the tests in any case.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

Test Results

   12 files    592 suites   2m 22s ⏱️
  589 tests   588 ✅ 1 💤 0 ❌
2 356 runs  2 351 ✅ 5 💤 0 ❌

Results for commit a864b15.

♻️ This comment has been updated with latest results.

@christianlupus christianlupus force-pushed the maintenance/fix-master-checks branch 2 times, most recently from 7176e45 to 4cce623 Compare February 8, 2026 18:44
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Copy link
Collaborator Author

/approve

@christianlupus christianlupus marked this pull request as ready for review February 9, 2026 12:14
Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus merged commit 2b6e320 into master Feb 9, 2026
19 checks passed
@christianlupus christianlupus deleted the maintenance/fix-master-checks branch February 9, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants