-
Notifications
You must be signed in to change notification settings - Fork 280
feat: make thread elements have the same space around them #11400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise
32e71a9
to
d9f283e
Compare
Nice improvements :) |
they will be done for sure, but in a separate pr :) |
src/components/Thread.vue
Outdated
&::before { | ||
content: ''; | ||
position: absolute; | ||
top: 0; | ||
left: 50%; | ||
transform: translateX(-50%); | ||
width: 100vw; | ||
height: 100%; | ||
background: var(--color-main-background); | ||
border-bottom: var(--border-width-input-focused) solid var(--color-border); | ||
z-index: -1; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO adjusting the width of the elements would have been preferable over this additional element
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i went for this because the border would lose the sticky position if i would do it like that. Either im doing something wrong with your proposal, or i dont know.
f4d601f
to
55d484f
Compare
Signed-off-by: greta <[email protected]>
55d484f
to
ec2173c
Compare
fixes #11316
Only worked on these points as added by Jan on the ticket:
before

after
after(reply button aligned with the action menu)

Subject and recipient aligned with the recipient in the message header. plus added the line to split subject from the message

more space for the preview, but this is a bit tricky to add more space for the preview because the details, the unread and the action menu wouldnt allow it to go further.

before
after
