Skip to content

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Jul 17, 2025

fixes #11316

Only worked on these points as added by Jan on the ticket:

  • The mail heading & participants should be aligned to the content box.
  • and the "Reply" button as well as the action buttons on the top right
  • When scrolling the content, the container / top divider line vanishes and gets overlapped partly by the heading, making it look strange
  • Now with the message list having more content, horizontal divider lines could make sense to have some nicer separation.
  • Mails have different heights in the message list if there’s shorter ones – but all should have the same consistent height
  • Whitespace is sometimes not the same across the board, for example the space left and right in the message list is much less (half?) than in the left navigation.

before
Screenshot from 2025-07-24 18-34-16
after

Screenshot from 2025-07-24 18-30-27

after(reply button aligned with the action menu)
Screenshot from 2025-07-24 18-29-59

Subject and recipient aligned with the recipient in the message header. plus added the line to split subject from the message
Screenshot from 2025-08-11 13-12-19

more space for the preview, but this is a bit tricky to add more space for the preview because the details, the unread and the action menu wouldnt allow it to go further.
before
Screenshot from 2025-07-24 18-37-18

after
Screenshot from 2025-07-24 17-27-46

@GretaD GretaD self-assigned this Jul 17, 2025
@GretaD GretaD changed the title feat: make thread elements have the same space around it feat: make thread elements have the same space around them Jul 17, 2025
@GretaD GretaD marked this pull request as ready for review July 24, 2025 16:40
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

@GretaD GretaD force-pushed the feat/subject-aligments branch from 32e71a9 to d9f283e Compare August 7, 2025 13:42
@nimishavijay
Copy link
Member

Nice improvements :)
I am wondering if the changes in the last part of this comment can be incorporated as well? Could be as a separate PR too #11065 (comment) also cc @hamza221 as you are assigned to that issue

@GretaD
Copy link
Contributor Author

GretaD commented Aug 12, 2025

Nice improvements :) I am wondering if the changes in the last part of this comment can be incorporated as well? Could be as a separate PR too #11065 (comment) also cc @hamza221 as you are assigned to that issue

they will be done for sure, but in a separate pr :)

Comment on lines 584 to 595
&::before {
content: '';
position: absolute;
top: 0;
left: 50%;
transform: translateX(-50%);
width: 100vw;
height: 100%;
background: var(--color-main-background);
border-bottom: var(--border-width-input-focused) solid var(--color-border);
z-index: -1;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO adjusting the width of the elements would have been preferable over this additional element

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i went for this because the border would lose the sticky position if i would do it like that. Either im doing something wrong with your proposal, or i dont know.

@GretaD GretaD force-pushed the feat/subject-aligments branch from 55d484f to ec2173c Compare August 12, 2025 13:16
@GretaD GretaD merged commit cfaef76 into main Aug 12, 2025
38 checks passed
@GretaD GretaD deleted the feat/subject-aligments branch August 12, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve element spacing, grouping and text densitiy
3 participants