Security: Internal exception messages are returned to clients#4634
Open
tomaioo wants to merge 1 commit intonextcloud:mainfrom
Open
Security: Internal exception messages are returned to clients#4634tomaioo wants to merge 1 commit intonextcloud:mainfrom
tomaioo wants to merge 1 commit intonextcloud:mainfrom
Conversation
The base controller returns raw exception messages in HTTP responses (`['message' => $e->getMessage()]`). If exception text contains internal details (query context, identifiers, stack-related hints), this can expose sensitive implementation information to attackers. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Internal exception messages are returned to clients
Problem
Severity:
Low| File:lib/Controller/BaseController.php:L47The base controller returns raw exception messages in HTTP responses (
['message' => $e->getMessage()]). If exception text contains internal details (query context, identifiers, stack-related hints), this can expose sensitive implementation information to attackers.Solution
Return generic user-facing error messages and log detailed exception information server-side only. Map known exceptions to stable, sanitized error codes/messages.
Changes
lib/Controller/BaseController.php(modified)