fix(IURLGenerator): Allow markdown parenthesis in URL_REGEX_NO_MODIFIERS #49334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: provokateurin <[email protected]>
provokateurin
requested review from
nickvergessen,
a team,
ArtificialOwl,
Altahrim and
come-nc
and removed request for
a team
nickvergessen
requested changes
Nov 16, 2024
There was a problem hiding this comment.
This needs extensive tests added to not break cases like:
Please check the website (https://nextcloud.com/)
Please check the website https://nextcloud.com/wikipedia_(has-braces)
And the likes. It was a long fight with usability of most users. So we really prefer broken previews over broken UX of normal users posting behaviour
Merged
|
If a URL has special characters, they must be encoded, no? I don't see how even the browser could work with it, if the URL is not encoded. |
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to nextcloud/spreed#13756.
Apparently the web UI doesn't use this regex but a hardcoded one, but I fixed it there as well: nextcloud-libraries/nextcloud-vue#6224
Clients should be using this regex, so it also needs to work with the parenthesis from embedded markdown links.
Checklist