refactor: Cleanup files app bootstrap#59831
Open
CarlSchwan wants to merge 2 commits intomasterfrom
Open
Conversation
CarlSchwan
requested review from
Altahrim and
ArtificialOwl
and removed request for
a team
CarlSchwan
requested review from
come-nc,
leftybournes,
provokateurin and
salmart-dev
susnux
approved these changes
Apr 22, 2026
Member
|
I have tried some of this before, but it was failing for reasons I didn't understand back then: #50875 |
CarlSchwan
force-pushed
the
work/carl/files-applications-cleanup
branch
2 times, most recently
from
fe5d86c to
de9bb96
Compare
Member
Author
I think the problematic part was in |
CarlSchwan
force-pushed
the
work/carl/files-applications-cleanup
branch
from
de9bb96 to
209276c
Compare
CarlSchwan
force-pushed
the
work/carl/files-applications-cleanup
branch
from
209276c to
5893d6c
Compare
DerDreschner
approved these changes
Apr 24, 2026
skjnldsv
approved these changes
Apr 24, 2026
come-nc
approved these changes
Apr 27, 2026
- Register event listener in the register method - Remove hook for injecting max_chunk_size in app config and move that code directly in JSConfigHelper - Remove getUserFolder deprecated API usage Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
work/carl/files-applications-cleanup
branch
from
5893d6c to
a77cc56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)