Skip to content

perf(system_tags): Optimize system tag activity recipient resolution for file mapper events #59931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mosi-kha wants to merge 1 commit into
base: master
Choose a base branch
from
+20 −5
Open

perf(system_tags): Optimize system tag activity recipient resolution for file mapper events #59931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions apps/systemtags/lib/Activity/Listener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,27 @@ public function mapperEvent(MapperEvent $event) {
$owner = $mount->getUser()->getUID();
$ownerFolder = $this->rootFolder->getUserFolder($owner);
$nodes = $ownerFolder->getById($event->getObjectId());
if (!empty($nodes)) {
/** @var Node $node */
$node = array_shift($nodes);
$al = $this->shareHelper->getPathsForAccessList($node);
$users += $al['users'];
if (empty($nodes)) {
continue;
}
/** @var Node $node */
$node = array_shift($nodes);
// Resolve the file in the true owner's home so access-list expansion
// is based on the canonical owner view even when the first hit came
// from a recipient/shared mount.
$fileOwner = $node->getOwner();
if ($fileOwner !== null) {
$ownerHome = $this->rootFolder->getUserFolder($fileOwner->getUID());
$ownerNodes = $ownerHome->getById($event->getObjectId());
if (!empty($ownerNodes)) {
$node = array_shift($ownerNodes);
}
}
// getPathsForAccessList() already expands all users that can access
// this file. One call is enough; repeating per mount was the hot path.
$al = $this->shareHelper->getPathsForAccessList($node);
$users = $al['users'];
break;
}

$actor = $this->session->getUser();
Expand Down