[WIP] Let guzzle choose the handler for http requests#60167
Draft
[WIP] Let guzzle choose the handler for http requests#60167
Conversation
…can write a streamed response body progressively Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/noid/allow-http-progressive-stream-response
branch
from
6eeca81 to
9c49a16
Compare
marcelklehr
reviewed
May 7, 2026
| #[\Override] | ||
| public function newClient(): IClient { | ||
| $handler = new CurlHandler(); | ||
| $handler = Utils::chooseHandler(); |
Member
Author
There was a problem hiding this comment.
It lets Guzzle choose the handler depending on the request options. So the StreamHandler is chosen when 'stream' => true is passed to the request options.
marcelklehr
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it can write a streamed response body progressively.
Summary
When using the
'stream' => truerequest option with IClient, the response body is a resource but its content is written all at once when the request is done.This happens because the use of the
CurlHandleris hardcoded in https://github.com/nextcloud/server/blob/fb67d5d/lib/private/Http/Client/ClientService.php#L44The Curlhandler makes a blocking call to
curl_execwhich executes the request synchronously.To allow progressive streamed responses, we need:
This is just a PoC. I have no idea if it's the right thing to do.
Wdyt?
Checklist
3. to review, feature component)stable32)AI (if applicable)