docs(group): clarify group listing API docs#60193
Open
joshtrichards wants to merge 3 commits intomasterfrom
Open
docs(group): clarify group listing API docs#60193joshtrichards wants to merge 3 commits intomasterfrom
joshtrichards wants to merge 3 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
No need to repeat public API bits Signed-off-by: Josh <josh.t.richards@gmail.com>
CarlSchwan
reviewed
May 7, 2026
| $ldap_groups = $this->access->nextcloudGroupNames($ldap_groups); | ||
|
|
||
| $this->access->connection->writeToCache($cacheKey, $ldap_groups); | ||
| return $ldap_groups; |
Member
There was a problem hiding this comment.
Suggested change
| return array_values($ldap_groups); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarifies the public
GroupInterface::getGroups()documentation to describe search/pagination behavior more accurately, and removes/trims redundant implementation docblocks in private group backends.Arose while looking at nextcloud/guests#1465, where I discovered its implementation doesn't even use the
$searchcriteria currently (fixing that there now separately).Checklist
3. to review, feature component)stable32)AI (if applicable)