chore: remove redundant ext-json requirement#60200
Closed
JoudAlqahtani wants to merge 1 commit intonextcloud:masterfrom
Closed
chore: remove redundant ext-json requirement#60200JoudAlqahtani wants to merge 1 commit intonextcloud:masterfrom
JoudAlqahtani wants to merge 1 commit intonextcloud:masterfrom
Conversation
ext-json has been bundled with PHP since PHP 8.0. Since Nextcloud requires PHP ^8.2, this requirement is redundant. Fixes nextcloud#58354 Signed-off-by: Joud <Joud@iastate.edu>
JoudAlqahtani
requested review from
leftybournes,
nfebe,
salmart-dev and
sorbaugh
and removed request for
a team
Member
|
Duplicate of #58370 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ext-json has been bundled with PHP since PHP 8.0.
Since Nextcloud requires PHP ^8.2, this requirement is redundant.
Fixes #58354
Summary
ext-json has been bundled with PHP since PHP 8.0.
Since Nextcloud requires PHP ^8.2, this explicit
requirement is redundant and can be safely removed.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)