fix(files_trashbin): misleading trashbin:expire output when expiration is disabled - #63040
Open
joshtrichards wants to merge 1 commit into
Open
fix(files_trashbin): misleading trashbin:expire output when expiration is disabled#63040joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
When trashbin_retention_obligation is set to disabled, trashbin:expire incorrectly reports the auto-expiration policy and exits with a failure status. Report that automatic expiration is disabled and exit successfully instead. Signed-off-by: Josh <josh.t.richards@gmail.com>
leftybournes
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trashbin_retention_obligation is set to disabled, trashbin:expire incorrectly reports the auto-expiration policy and exits with a failure status.
Report that automatic expiration is disabled and exit successfully instead.
Summary
Discovered while working on nextcloud/documentation#15421
Fixes the output and exit status of
occ trashbin:expirewhen automatic trash-bin expiration is disabled with:When expiration is disabled,
trashbin:expirecurrently prints a message describing the default auto policy:It also exits with status
1, even though the configured state is valid and no operation has failed.This is misleading.
Changes:
0for this valid no-op condition.Only updates
occ trashbin:expireoutput/return value behavior for the disabled retention policy. It does not change retention-policy semantics or the behavior oftrashbin:cleanupor any other aspect of the implementation.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)