Skip to content

feat(skill): add github-dashboard#666

Open
joeylee12629-star wants to merge 3 commits intomainfrom
feat/github-dashboard-skill
Open

feat(skill): add github-dashboard#666
joeylee12629-star wants to merge 3 commits intomainfrom
feat/github-dashboard-skill

Conversation

@joeylee12629-star
Copy link
Copy Markdown
Contributor

@joeylee12629-star joeylee12629-star commented May 6, 2026

Summary

  • Add github-dashboard, a desktop prototype skill for GitHub repository analytics: stars, forks, contributors, issues, PRs, recent activity, and top contributors.
  • Include a live-artifact-compatible reference template plus normalized example data and safe provenance notes.
  • Ship a default rendered example for nexu-io/open-design so reviewers can inspect the intended visual output without running the skill.

Default Render

github-dashboard default render

Validation

  • corepack pnpm guard
  • corepack pnpm --filter @open-design/daemon exec vitest run -c vitest.config.ts tests/skills.test.ts tests/skill-id-aliases.test.ts tests/skill-asset-rewrite.test.ts

Notes: full typecheck did not complete because the root script invokes a bare pnpm shim that is unavailable in this shell. Full daemon tests are blocked in this environment by a Node v25.8.2 / better-sqlite3 ABI mismatch; the skill registry and asset rewrite tests passed.

@lefarcen lefarcen self-requested a review May 6, 2026 10:47
@lefarcen lefarcen added the feature New feature or enhancement label May 6, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 37c7bc87a0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread skills/github-dashboard/references/template.html Outdated
Copy link
Copy Markdown
Contributor

@lefarcen lefarcen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @joeylee12629-star! 🎉

Thanks for adding this new skill. I've reviewed all 6 files against both lenses (code correctness + reasoning completeness) and found 4 must-fix issues and 5 should-fix improvements. The skill has solid visual design and follows most conventions, but there are critical gaps in the live-artifact contract and template repeatability that would break agent execution.

Summary of P1 blockers:

  1. Live template has invalid repeat bindings — will fail or render blank
  2. Missing required data-od-id tags — breaks comment-mode targeting
  3. Inconsistent live-artifact output spec — agents will produce incomplete artifacts
  4. Data schema mismatch between docs/example/template — will cause binding errors

See inline comments for specifics. Most are straightforward fixes. Happy to clarify any of these!

Comment thread skills/github-dashboard/references/template.html Outdated
Comment thread skills/github-dashboard/example.html
Comment thread skills/github-dashboard/SKILL.md
Comment thread skills/github-dashboard/references/example-data.json
Comment thread skills/github-dashboard/example.html
Comment thread skills/github-dashboard/example.html
Comment thread skills/github-dashboard/SKILL.md
Comment thread skills/github-dashboard/references/provenance-example.json
Comment thread skills/github-dashboard/SKILL.md Outdated
Copy link
Copy Markdown
Contributor

@mrcfps mrcfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeylee12629-star thanks for the thoughtful addition here — the dashboard direction and reference assets are promising. I found a couple of live-template correctness issues that would make refreshed artifacts render the wrong data, so I'm requesting changes to keep the new skill reliable for agents and users.

Generated by Looper 0.6.0 · runner=reviewer · agent=opencode

Comment thread skills/github-dashboard/references/template.html Outdated
Comment thread skills/github-dashboard/references/template.html Outdated
Copy link
Copy Markdown
Contributor

@mrcfps mrcfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeylee12629-star thanks for continuing to tighten up the GitHub dashboard skill. I found one blocking validation gap: the new skill is registered, but the localized display metadata expected by CI is not present yet, so the workspace validation is red. 🙏

Fallback location: skills/github-dashboard/SKILL.md, frontmatter name: github-dashboard (line 2). The new github-dashboard skill is now part of the curated skill set, but the PR does not add matching localized display copy for every required locale. Evidence: the live Validate workspace check fails in e2e/tests/localized-content.test.ts because the expected skill IDs include github-dashboard, while the localized skill-display IDs for de, ru, and fr are missing it. That blocks merge because required workspace validation no longer passes and users in those locales would not have display metadata for this newly registered skill. Please add github-dashboard entries to the localized skill display content sources used for de, ru, and fr (matching the title/description shape used by the neighboring skills), then rerun the localized-content test or CI.

Generated by Looper 0.6.1 · runner=reviewer · agent=opencode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants