feat(skill): add github-dashboard#666
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37c7bc87a0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
lefarcen
left a comment
There was a problem hiding this comment.
Hi @joeylee12629-star! 🎉
Thanks for adding this new skill. I've reviewed all 6 files against both lenses (code correctness + reasoning completeness) and found 4 must-fix issues and 5 should-fix improvements. The skill has solid visual design and follows most conventions, but there are critical gaps in the live-artifact contract and template repeatability that would break agent execution.
Summary of P1 blockers:
- Live template has invalid repeat bindings — will fail or render blank
- Missing required
data-od-idtags — breaks comment-mode targeting - Inconsistent live-artifact output spec — agents will produce incomplete artifacts
- Data schema mismatch between docs/example/template — will cause binding errors
See inline comments for specifics. Most are straightforward fixes. Happy to clarify any of these!
mrcfps
left a comment
There was a problem hiding this comment.
@joeylee12629-star thanks for the thoughtful addition here — the dashboard direction and reference assets are promising. I found a couple of live-template correctness issues that would make refreshed artifacts render the wrong data, so I'm requesting changes to keep the new skill reliable for agents and users.
Generated by Looper 0.6.0 · runner=reviewer · agent=opencode
mrcfps
left a comment
There was a problem hiding this comment.
@joeylee12629-star thanks for continuing to tighten up the GitHub dashboard skill. I found one blocking validation gap: the new skill is registered, but the localized display metadata expected by CI is not present yet, so the workspace validation is red. 🙏
Fallback location: skills/github-dashboard/SKILL.md, frontmatter name: github-dashboard (line 2). The new github-dashboard skill is now part of the curated skill set, but the PR does not add matching localized display copy for every required locale. Evidence: the live Validate workspace check fails in e2e/tests/localized-content.test.ts because the expected skill IDs include github-dashboard, while the localized skill-display IDs for de, ru, and fr are missing it. That blocks merge because required workspace validation no longer passes and users in those locales would not have display metadata for this newly registered skill. Please add github-dashboard entries to the localized skill display content sources used for de, ru, and fr (matching the title/description shape used by the neighboring skills), then rerun the localized-content test or CI.
Summary
github-dashboard, a desktop prototype skill for GitHub repository analytics: stars, forks, contributors, issues, PRs, recent activity, and top contributors.nexu-io/open-designso reviewers can inspect the intended visual output without running the skill.Default Render
Validation
corepack pnpm guardcorepack pnpm --filter @open-design/daemon exec vitest run -c vitest.config.ts tests/skills.test.ts tests/skill-id-aliases.test.ts tests/skill-asset-rewrite.test.tsNotes: full
typecheckdid not complete because the root script invokes a barepnpmshim that is unavailable in this shell. Full daemon tests are blocked in this environment by a Nodev25.8.2/better-sqlite3ABI mismatch; the skill registry and asset rewrite tests passed.