Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### `Added`

- [#873](https://github.com/nf-core/mag/pull/873) - Document usage of `longread_percentidentity` and `shortread_percentidentity` and set the value of `longread_percentidentity` in the `test_full` profile to 85 (by @prototaxites)
- [#875](https://github.com/nf-core/mag/pull/875) - Add binner COMEBin (by @d4straub)

### `Changed`

Expand Down
21 changes: 21 additions & 0 deletions conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -806,6 +806,23 @@ process {
ext.prefix = { "${meta.assembler}-CONCOCT-${meta.id}" }
}

withName: COMEBIN_RUNCOMEBIN {
publishDir = [
[
path: { "${params.outdir}/GenomeBinning/COMEBin/stats/" },
mode: params.publish_dir_mode,
pattern: '*.{log,tsv}',
],
[
path: { "${params.outdir}/GenomeBinning/COMEBin/bins/" },
mode: params.publish_dir_mode,
pattern: '*.fa.gz',
],
]
ext.prefix = { "${meta.assembler}-COMEBin-${meta.id}" }
// ext.args = "-b 20" // default value fails with "-profile test" (100 passes that step) as in https://github.com/ziyewang/COMEBin/issues/4 but the binner fails later after: "[CheckM - analyze] Identifying marker genes in bins."
}

withName: SEQKIT_STATS {
ext.args = ""
publishDir = [enabled: false]
Expand All @@ -827,6 +844,10 @@ process {
ext.prefix = { "${meta.assembler}-CONCOCT-${meta.id}" }
}

withName: DASTOOL_FASTATOCONTIG2BIN_COMEBIN {
ext.prefix = { "${meta.assembler}-COMEBin-${meta.id}" }
}

withName: DASTOOL_FASTATOCONTIG2BIN_TIARA {
ext.prefix = { "${meta.assembler}-${meta.binner}-${meta.id}" }
}
Expand Down
1 change: 1 addition & 0 deletions conf/test.config
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ params {
max_unbinned_contigs = 2
// Including (even length filtered) CONOCT bins adds another 5 minutes, so we skip it in the default test (testing in assemblyinput)
skip_concoct = true
skip_comebin = true
busco_db = params.pipelines_testdata_base_path + 'mag/databases/busco/bacteria_odb10.2024-01-08.tar.gz'
busco_db_lineage = 'bacteria_odb10'
busco_clean = true
Expand Down
1 change: 1 addition & 0 deletions conf/test_alternatives.config
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ params {
skip_gtdbtk = true
skip_maxbin2 = true
skip_concoct = true
skip_comebin = true
skip_metaeuk = true
megahit_fix_cpu_1 = true
}
1 change: 1 addition & 0 deletions conf/test_assembly_input.config
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ params {
skip_prokka = true
skip_gtdbtk = true
skip_concoct = false
skip_comebin = true

refine_bins_dastool = true
refine_bins_dastool_threshold = 0.0
Expand Down
1 change: 1 addition & 0 deletions conf/test_hybrid.config
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ params {
skip_metamdbg = true
skip_gtdbtk = true
skip_concoct = true
skip_comebin = true

spadeshybrid_fix_cpus = 2
}
1 change: 1 addition & 0 deletions conf/test_longreadonly.config
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,5 @@ params {

skip_gtdbtk = true
skip_concoct = true
skip_comebin = true
}
1 change: 1 addition & 0 deletions conf/test_longreadonly_alternatives.config
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,6 @@ params {
skip_prokka = true
skip_gtdbtk = true
skip_concoct = true
skip_comebin = true
skip_metaeuk = true
}
1 change: 1 addition & 0 deletions conf/test_minimal.config
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ params {
skip_metabat2 = true
skip_maxbin2 = true
skip_concoct = true
skip_comebin = true
skip_prokka = true
skip_binqc = true
skip_gtdbtk = true
Expand Down
1 change: 1 addition & 0 deletions conf/test_single_end.config
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ params {
bcftools_view_high_variant_quality = 0
bcftools_view_medium_variant_quality = 0
bcftools_view_minimal_allelesupport = 3
skip_comebin = true
min_length_unbinned_contigs = 1000000
max_unbinned_contigs = 2
binqc_tool = 'checkm'
Expand Down
5 changes: 5 additions & 0 deletions modules.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@
"git_sha": "41dfa3f7c0ffabb96a6a813fe321c6d1cc5b6e46",
"installed_by": ["modules"]
},
"comebin/runcomebin": {
"branch": "master",
"git_sha": "b153ee540a64472fef22a0699040238dcd422bfc",
"installed_by": ["modules"]
},
"concoct/concoct": {
"branch": "master",
"git_sha": "ff39793aeff17b7ccb107424215898710b4aa424",
Expand Down
7 changes: 7 additions & 0 deletions modules/nf-core/comebin/runcomebin/environment.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

73 changes: 73 additions & 0 deletions modules/nf-core/comebin/runcomebin/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

110 changes: 110 additions & 0 deletions modules/nf-core/comebin/runcomebin/meta.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

47 changes: 47 additions & 0 deletions modules/nf-core/comebin/runcomebin/tests/main.nf.test

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading