Skip to content

Conversation

@famosab
Copy link
Collaborator

@famosab famosab commented Oct 28, 2025

PR checklist

Closes #29

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/variantprioritization branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit da6ae01

+| ✅ 235 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗  81 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: .github/workflows/ci.yml
  • files_unchanged - File ignored due to lint config: assets/nf-core-variantprioritization_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-variantprioritization_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-variantprioritization_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore

✅ Tests passed:

Run details

  • nf-core/tools version 3.4.1
  • Run at 2025-10-28 14:17:40

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

@famosab
Copy link
Collaborator Author

famosab commented Oct 28, 2025

So we are getting md5sum mismatches for now - will merge this anyway (because someone else is working on a proper test setup with VEP cache an so on see #26)

@famosab famosab changed the title T3.4.1 Template update to 3.4.1 Oct 28, 2025
@famosab famosab merged commit 510c3e7 into dev Oct 28, 2025
5 of 7 checks passed
@famosab famosab deleted the t3.4.1 branch October 28, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

template update to 3.4.1

4 participants