utilities.dart: Check if sub_cards exists before accessing its length#39
Merged
Conversation
Data of v2.4.0 does not have sub_cards in its card data. In such situation if user upgrade the app to version with multi-card support without cleaning its old data, a red error page will show up instead of card data. And the only way for user to continue to use nfsee would be clean all existing data, which is not good. With this patch, we check if the sub_cards exists before trying to display card info. As a result, users can have a better upgrade experience. Signed-off-by: Zamir SUN <sztsian@gmail.com>
dangfan
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data of v2.4.0 does not have sub_cards in its card data. In such situation if user upgrade the app to version with multi-card support without cleaning its old data, a red error page will show up instead of card data. And the only way for user to continue to use nfsee would be clean all existing data, which is not good.
With this patch, we check if the sub_cards exists before trying to display card info. As a result, users can have a better upgrade experience.