Skip to content

Integration tests for N1C metrics #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Integration tests for N1C metrics #1210

wants to merge 22 commits into from

Conversation

spencerugbo
Copy link
Contributor

Proposed changes

This PR aims to add integration tests for N1C metrics.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@spencerugbo spencerugbo self-assigned this Aug 12, 2025
@spencerugbo spencerugbo requested a review from a team as a code owner August 12, 2025 16:24
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation labels Aug 12, 2025
@spencerugbo spencerugbo changed the title Integration tests for n1c metrics Integration tests for N1C metrics Aug 12, 2025
john-david3
john-david3 reviewed Aug 13, 2025
View reviewed changes
test/helpers/test_containers_utils.go Outdated
// osVersion := Env(tb, "OS_VERSION")
buildTarget := Env(tb, "BUILD_TARGET")
dockerfilePath := Env(tb, "DOCKERFILE_PATH")
// containerRegistry := Env(tb, "CONTAINER_NGINX_IMAGE_REGISTRY")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code block is all commented out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into an issue with setting up the container for agent with NGINX Plus so I commented out the code for now until I can sort it.

@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Aug 14, 2025
craigell
craigell reviewed Aug 15, 2025
View reviewed changes
craigell
craigell reviewed Aug 15, 2025
View reviewed changes
craigell
craigell reviewed Aug 15, 2025
View reviewed changes
craigell
craigell reviewed Aug 15, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigell craigell craigell approved these changes

+1 more reviewer

@john-david3 john-david3 john-david3 left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

@spencerugbo spencerugbo

Labels
chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spencerugbo @craigell @john-david3 @dhurley