Update NGINX Plus in Integration Tests #1212
Merged
+21
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigell
reviewed
Aug 19, 2025
| @@ -175,6 +176,21 @@ func setupNginxContainer( | |||
| if os.Getenv("IMAGE_PATH") == "/nginx-plus/agent" { | |||
| nginxConfPath = "../../config/nginx/nginx-plus.conf" | |||
| } | |||
| if os.Getenv("NGINX_LICENSE_JWT") != "" { | |||
| tb.Log("Using NGINX license JWT from environment variable") | |||
| tb.Logf("jwt contents: %s", os.Getenv("NGINX_LICENSE_JWT")) | |||
There was a problem hiding this comment.
Think we can remove this log line. It won't be needed and it won't show the contents of the jwt since it's a github secret.
craigell
approved these changes
Aug 28, 2025
dhurley
approved these changes
Sep 9, 2025
sean-breen
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update the NGINX Plus version used for official integration tests in the CI workflow
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)