-
Notifications
You must be signed in to change notification settings - Fork 138
Add support for backend tls config for Gateways #3900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -139,6 +139,14 @@ const ( | |
// parametersRef resource is invalid. | ||
GatewayReasonParamsRefInvalid v1.GatewayConditionReason = "ParametersRefInvalid" | ||
|
||
// GatewayReasonSecretRefInvalid is used with the "GatewayResolvedRefs" condition when the | ||
// secretRef resource is invalid. | ||
GatewayReasonSecretRefInvalid v1.GatewayConditionReason = "SecretRefInvalid" | ||
|
||
// GatewayReasonSecretRefNotPermitted is used with the "GatewayResolvedRefs" condition when the | ||
// secretRef resource is not permitted by any ReferenceGrant. | ||
GatewayReasonSecretRefNotPermitted v1.GatewayConditionReason = "SecretRefNotPermitted" | ||
|
||
// PolicyReasonAncestorLimitReached is used with the "PolicyAccepted" condition when a policy | ||
// cannot be applied because the ancestor status list has reached the maximum size of 16. | ||
PolicyReasonAncestorLimitReached v1alpha2.PolicyConditionReason = "AncestorLimitReached" | ||
|
@@ -297,6 +305,27 @@ func NewGatewayClassUnsupportedVersion(recommendedVersion string) []Condition { | |
} | ||
} | ||
|
||
// NewGatewaySecretRefNotPermitted returns Condition that indicates that the Gateway references a TLS secret that is not | ||
// permitted by any ReferenceGrant. | ||
func NewGatewaySecretRefNotPermitted(msg string) Condition { | ||
return Condition{ | ||
Type: string(GatewayReasonResolvedRefs), | ||
Status: metav1.ConditionFalse, | ||
Reason: string(GatewayReasonSecretRefNotPermitted), | ||
Message: msg, | ||
} | ||
} | ||
|
||
// NewGatewaySecretRefInvalid returns Condition that indicates that the Gateway references a TLS secret that is invalid. | ||
func NewGatewaySecretRefInvalid(msg string) Condition { | ||
return Condition{ | ||
Type: string(GatewayReasonResolvedRefs), | ||
Status: metav1.ConditionFalse, | ||
Reason: string(GatewayReasonSecretRefInvalid), | ||
Message: msg, | ||
} | ||
} | ||
|
||
Comment on lines
+310
to
+328
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. currently working on the bug related to marking HTTPRoute invalid leading to issues and I am wondering if this is still valid? Should we mark the gateway invalid? its not syntactically wrong for it to be marked false. We just won't reference the secret in the our configuration so I would like to change this to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Gateway API community may be able to clarify for sure, but I'm fairly confident this should be |
||
// NewGatewayClassConflict returns a Condition that indicates that the GatewayClass is not accepted | ||
// due to a conflict with another GatewayClass. | ||
func NewGatewayClassConflict() Condition { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these available or will these be available to import from the gateway api?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, these weren't available on gateway api only reason related to parametersRef so didn't want to use those to avoid confusion