Skip to content

Conversation

@salonichf5
Copy link
Contributor

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: Users want to specify load balancing method via Upstream Settings Policy API

Solution: Extend Upstream settings policy API to support load balancing method field.

Testing: Manual testing applying CRDs

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #4229

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Add a `loadBalancingMethod` field to the Upstream Settings Policy API 

@salonichf5 salonichf5 requested a review from a team as a code owner November 11, 2025 05:23
@github-actions github-actions bot added enhancement New feature or request tests Pull requests that update tests labels Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.13%. Comparing base (9d2bf35) to head (6fa5e7d).
⚠️ Report is 1 commits behind head on feat/session-persistence.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           feat/session-persistence    #4251      +/-   ##
============================================================
+ Coverage                     86.11%   86.13%   +0.01%     
============================================================
  Files                           131      131              
  Lines                         14205    14205              
  Branches                         35       35              
============================================================
+ Hits                          12233    12235       +2     
+ Misses                         1768     1766       -2     
  Partials                        204      204              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@salonichf5 salonichf5 force-pushed the feat/update-upstream-api branch 3 times, most recently from fef5236 to 588c0a5 Compare November 11, 2025 05:53
Copy link
Collaborator

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind updating the PR title to be more descriptive about what you're actually updating?

@salonichf5 salonichf5 changed the title Update Upstream settings policy API Add a loadBalancingMethod field to the Upstream Settings Policy API Nov 11, 2025
@salonichf5 salonichf5 changed the title Add a loadBalancingMethod field to the Upstream Settings Policy API Add a loadBalancingMethod field to the Upstream Settings Policy API Nov 11, 2025
@salonichf5 salonichf5 force-pushed the feat/update-upstream-api branch from 588c0a5 to a03330c Compare November 11, 2025 17:39
@github-actions github-actions bot added helm-chart Relates to helm chart and removed tests Pull requests that update tests labels Nov 11, 2025
@salonichf5 salonichf5 changed the base branch from feat/session-persistence to main November 11, 2025 17:44
@salonichf5 salonichf5 changed the base branch from main to feat/session-persistence November 11, 2025 17:44
@salonichf5 salonichf5 requested a review from sjberman November 11, 2025 17:45
@github-actions github-actions bot removed the helm-chart Relates to helm chart label Nov 11, 2025
@salonichf5 salonichf5 requested a review from sjberman November 11, 2025 21:15
@salonichf5 salonichf5 force-pushed the feat/update-upstream-api branch from 985d2ff to 6fa5e7d Compare November 11, 2025 21:57
@salonichf5 salonichf5 merged commit 70bba4d into feat/session-persistence Nov 12, 2025
54 of 56 checks passed
@salonichf5 salonichf5 deleted the feat/update-upstream-api branch November 12, 2025 00:48
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Nov 12, 2025
salonichf5 added a commit that referenced this pull request Nov 12, 2025
…4251)

Problem: Users want to specify load balancing method via Upstream Settings Policy API

Solution: Extend Upstream settings policy API to support load balancing method field.
salonichf5 added a commit that referenced this pull request Nov 13, 2025
…4251)

Problem: Users want to specify load balancing method via Upstream Settings Policy API

Solution: Extend Upstream settings policy API to support load balancing method field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release-notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Update the Upstream Settings Policy API to support load balancing method field

4 participants