Update N+ license handling to reflect reporting section presence #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was an assumption that `/api/9/license` will always include the `reporting` subtree, and if it was absent, related values were populated with zeroes [1] making the whole struct hard to rely on. With this change, NginxLicense.Reporting will be a pointer to the original subtree if it present in the API response, or nil otherwise. [1] https://betterstack.com/community/guides/scaling-go/json-in-go/#2-missing-fields-fallback-to-zero-values
6 tasks
defanator
added a commit
to defanator/nginx-prometheus-exporter
that referenced
this pull request
Jul 25, 2025
This one depends on pending PR in nginx-plus-go-client: nginx/nginx-plus-go-client#528
dhurley
approved these changes
Jul 28, 2025
vepatel
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously there was an assumption that
/api/9/licensewill always include thereportingsubtree (docs), and if it was absent, related values were populated with zeroes making the whole struct hard to rely on.With the proposed change,
NginxLicense.Reportingwill be a pointer to the original subtree if it present in the API response, or nil otherwise.Related to nginx/nginx-prometheus-exporter#1102.
May potentially break other consumers of this package (e.g. https://github.com/nginx/kubernetes-ingress, https://github.com/nginx/nginx-prometheus-exporter) - future dep updates will require appropriate changes.
Checklist
Before creating a PR, run through this checklist and mark each as complete.