Killing Oldframe #276
Open
Killing Oldframe #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Playwright visual snapshot differences were detected.View the Playwright report |
✅ Deploy Preview will be available once build job completes!
|
|
Tab groups not working as expected - taking a look. |
|
F5 Sites button not working as expected as well. Related to the tabs group. Edit: Resolved |
❌ One or more of the commit messages in this PR do not match the nginx-hugo-theme git guidelines, please check the CI job for more details on which commits were flagged and why.Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR. |
lamATnginx
force-pushed
the
mainframe
branch
3 times, most recently
from
0f6ac99 to
6de8fe8
Compare
TasoOneAsia
requested changes
Jun 17, 2025
Update reset to include `pre` tag for code block
Reduced "Last modified" section date Remove horizontal rule from survey section
* Icon: Refactored to icon shortcode instead of fe + updated old icon code * Icon: Fixed lucide partial * Icon: Removed feather references
Signed-off-by: Lam Nguyen <[email protected]>
Fix rendering coveo suggestions
Noticed that on hard page refreshes, and slower connections that I would still see the extra vertical overflow caused by coveo. I assumed it was a race condition, and wrapping the removal of `atomic-relevance-inspector` in a timeout, would generally resolve it. I didn't want a timeout to be the "fix" here, so I added the Mutation Observer (https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver) which appears to be the safest approach. There's an overall 5 second timeout still, in case search never renders for whatever reason.
Coveo: Fix vertical overflow race condition
* Spacing: Add margin variables throughout Attempt to match figma spacing with headings Add variables for ol and ul colours * Spacing: Add callout and tab group spacing * Icons: Fix icon usage in callouts * Callout: Fix margin and whitespace in side callouts * Typography: Wrap headers in .content class Fix h1s on list pages not lining up with images * Homepage: Fix card text overflow * Content: Fix narrow content shifting between pages * Layout: Fix outer container padding
Sidebar: Fix overflow missing some lines
…ages (#326) * Redocly: Fix width issues * Redoc: Fix auto scroll issue
* Qualtrics: Fixed survey going over sidebar * Qualtrics: Fixed responsiveness
* Card: Handle case of no inner for cards * Card: Updated test product landing page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Lots of removing
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.mdandCHANGELOG.md)