type with {length: number} instead of never#407
Merged
NetanelBasal merged 2 commits intongneat:mainfrom Jul 13, 2025
tayambamwanza:fix/to-collection-length-default
Merged
type with {length: number} instead of never#407NetanelBasal merged 2 commits intongneat:mainfrom tayambamwanza:fix/to-collection-length-default
NetanelBasal merged 2 commits intongneat:mainfrom
tayambamwanza:fix/to-collection-length-default
Conversation
|
|
| */ | ||
|
|
||
| export function toCollection<Collection, Options extends FakeOptions = never>( | ||
| export function toCollection<Collection, Options extends FakeOptions = {length: number}>( |
Member
There was a problem hiding this comment.
please add a test in collection.spec
Contributor
Author
There was a problem hiding this comment.
@NetanelBasal hopefully the test that I added is sufficient?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
Other information