feat: 🎸 DOMSelector support for query parentSelector#732
Merged
NetanelBasal merged 1 commit intongneat:masterfrom Oct 12, 2025
Merged
Conversation
Allow usage of byTestId(), byText(), byRole(), etc in query's parentSelector
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow usage of
byTestId(),byText(),byRole(), etc in query'sparentSelectorPR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently css selector have to be used to query for data-testid attribute
What is the new behavior?
Support
DomSelectorto allow existing dom query functions to be used:byTestId(),byText(),byRole(), etc... inparentSelectorDoes this PR introduce a breaking change?
Other information