Add Vale vocabulary list #1674
Add Vale vocabulary list #1674
Conversation
sg-writer
added
kind/enhancement
sg-writer
force-pushed
the
sg/doc-448-create-vale-word-list-covering-all-ngrokisms
branch
from
f4989ff to
ebde684
Compare
| }); | ||
|
|
||
| // Output ngrok url to console | ||
| // Output ngrok URL to console |
There was a problem hiding this comment.
As a passing question, is there any way to make this ignore code snippets? In this case, it's a good change, but I think it'd be weird if you got a vale error for a variable name
There was a problem hiding this comment.
I do need to look into how to fine-tune it that way - I had to remove a rule enforcing lowercase "ngrok" because sometimes it appears in the code as NgrokFooBar 🙃
|
|
||
| <Note> | ||
| Ensure your chosen domain has the proper TLS/SSL certs provisioned in order to create a secure, working connection. | ||
| Ensure your chosen domain has the proper TLS/SSL certs provisioned to create a secure, working connection. |
There was a problem hiding this comment.
Nice. "in order to" is the bane of my existence
There was a problem hiding this comment.
once we turn Vale back on in the dashboard "in order to" should fail the CI check and force you to delete it before merging 😈
sg-writer
deleted the
sg/doc-448-create-vale-word-list-covering-all-ngrokisms
branch
There was a problem hiding this comment.
This file is generated so the main repo is going to put this back.
There was a problem hiding this comment.
This file is generated so the main repo is going to put this back.
This PR:
We should be able to safely turn Vale CI checks back on in the Mintlify dashboard after this PR is merged. There might be some unnecessary noise from warnings and suggestions at first but we can continue to iterate on them to make them useful.