Skip to content

style(www): remove margin on code-example #4889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

style(www): remove margin on code-example #4889

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0398d07
style(www): remove margin on code-example
jdegand Jul 18, 2025
57ea926
style(www): add missing px
jdegand Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions projects/www/src/app/components/docs/code-example.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { Component, Input } from '@angular/core';
display: flex;
flex-direction: column;
border: 1px solid rgba(255, 255, 255, 0.12);
margin: 14px 0 24px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to keep the margin in some cases, otherwise the code is "too attached" to the text above it.

Image

Previously:

Image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard-coding margin makes the component inflexible. Maybe, it is better to add an input for margin styling. If you add just margin-top: 8px to the component, you'll likely have a situation where a double margin is created somewhere. You could place a class on the app-code-example component and use that to handle margins.

}

.header {
Expand All @@ -27,7 +26,7 @@ import { Component, Input } from '@angular/core';
}

.body {
padding: 0 0px;
padding: 0px 0px;
overflow-x: wrap;
}
`,
Expand Down