Use absolute URL for checkbox image to avoid issue on Firefox#62
Merged
Use absolute URL for checkbox image to avoid issue on Firefox#62
Conversation
m-akinc
requested review from
atmgrifter00,
cameronwaterman and
rajsite
as code owners
rajsite
approved these changes
Sep 9, 2025
saradei-ni
pushed a commit
that referenced
this pull request
Jan 27, 2026
Fixes AzDO bug: https://dev.azure.com/ni/DevCentral/_workitems/edit/3207943 Previous commit did not fix the issue completely. It fixed the issue when loading fonts from the main Dashboards page, but not when loading the checkbox image upon opening a multi-select dropdown. Using an absolute path avoids the issue, so now prepending the document.baseURI to the relative path. STILL NECESSARY? If you can run the validation described below without this change, then apparently we don't need it anymore. VALIDATION: Launch the Dashboards app in Firefox Find/create a dashboard with a multi-option dropdown (e.g. asset selector), and ensure the checkbox images are loaded. There shouldn't be any 404 error in the devtools network tab for the checkbox image fetch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AzDO bug: https://dev.azure.com/ni/DevCentral/_workitems/edit/3207943
Previous commit did not fix the issue completely. It fixed the issue when loading fonts from the main Dashboards page, but not when loading the checkbox image upon opening a multi-select dropdown.
Using an absolute path avoids the issue, so now prepending the
document.baseURIto the relative path.STILL NECESSARY?
There's not a bulletproof way to tell if a new Grafana version obviates the need for this change. If you can run the validation described below without this change, then apparently we don't need it anymore.
VALIDATION: