Skip to content

Pin bingo version to 0.9.0 #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ahalya-ni wants to merge 2 commits into from
Closed

Pin bingo version to 0.9.0 #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a5688b
updated dockerfile and change yml to not push the image
Ahalya-ni Jan 21, 2026
7aa49be
comment out the jfrog protection rules
Ahalya-ni Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,25 +29,27 @@ jobs:
name: Build Docker Image
needs: [generate_version_number]
runs-on: ubuntu-latest
environment: jfrog-ci
# environment: jfrog-ci # Disabled for testing - not needed when push: false
Copy link
Author

@Ahalya-ni Ahalya-ni Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

steps:
- uses: actions/checkout@v2
- name: Login to Artifactory
uses: docker/login-action@v1
with:
registry: niartifacts.jfrog.io
username: ${{ vars.JFROG_USERNAME }}
password: ${{ secrets.JFROG_ACCESS_TOKEN }}
# Login disabled for testing since we're not pushing
# - name: Login to Artifactory
# uses: docker/login-action@v1
# with:
# registry: niartifacts.jfrog.io
# username: ${{ vars.JFROG_USERNAME }}
# password: ${{ secrets.JFROG_ACCESS_TOKEN }}
- name: Docker build and push
uses: docker/build-push-action@v2
with:
context: .
push: true
push: false
tags: |
niartifacts.jfrog.io/rnd-docker-ci/ni/systemlink/ni-grafana:latest
niartifacts.jfrog.io/rnd-docker-ci/ni/systemlink/ni-grafana:${{ needs.generate_version_number.outputs.image_version }}
sign_docker_image:
name: Sign Docker Image
if: false
needs: [generate_version_number, build_docker_image]
runs-on: ubuntu-latest
environment: jfrog-ci
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ COPY pkg/plugins/codegen pkg/plugins/codegen

RUN go mod download
RUN if [[ "$BINGO" = "true" ]]; then \
go install github.com/bwplotka/bingo@latest && \
go install github.com/bwplotka/bingo@v0.9.0 && \
bingo get -v; \
fi

Expand Down
Loading