Repository navigation
Handle reads that don't match Waveform length - #819
Merged
mikeprosserni merged 13 commits intoSep 9, 2025
Merged
Conversation
Contributor
Test Results 38 files ± 0 38 suites ±0 1h 3m 13s ⏱️ +17s Results for commit d86c7c6. ± Comparison against base commit faf34c9. This pull request removes 8 and adds 24 tests. Note that renamed tests count towards both.This pull request removes 4 skipped tests and adds 12 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
mikeprosserni
marked this pull request as ready for review
September 3, 2025 21:19
mikeprosserni
requested review from
bkeryan,
maxxboehme and
zhindes
as code owners
September 3, 2025 21:19
zhindes
approved these changes
Sep 3, 2025
bkeryan
reviewed
Sep 5, 2025
bkeryan
requested changes
Sep 5, 2025
bkeryan
reviewed
Sep 6, 2025
1 of 3 tasks
added 8 commits
September 8, 2025 11:19
…-3228924-set-sample-count
…ionPolicy.TO_GROW
…-3228924-set-sample-count
bkeryan
requested changes
Sep 8, 2025
bkeryan
reviewed
Sep 8, 2025
bkeryan
approved these changes
Sep 9, 2025
mikeprosserni
deleted the
users/mprosser/task-3228924-set-sample-count
branch
September 9, 2025 21:40
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated CHANGELOG.md if applicable.What does this Pull Request accomplish?
This PR takes advantage of the newly-settable
waveform.sample_countproperty to adjust the waveform size in two scenarios:If the data available to be read was less than the size of the waveform, (a "short read"), then the waveform's sample count will be lowered to match the actual amount of available data read.
If the data available to be read was greater than the size of the waveform (and the new
InStream.reallocation_policyis set toTO_GROW), then the waveform's sample count will be increased to accommodate all the available data.The new
ReallocationPolicyenum is based on the one in the .NET API.Why should this Pull Request be merged?
AB#3228924
What testing has been done?