Use JS for updating height of the Chat Input control#2901
Open
hellovolcano wants to merge 3 commits intomainfrom
Open
Use JS for updating height of the Chat Input control#2901hellovolcano wants to merge 3 commits intomainfrom
hellovolcano wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
The Spright Chat Input is currently pulled in to an application that's being hosted in CEF 119.4.3, which does not yet have support for field-sizing as described in this bug. The long-term fix is to upgrade CEF, but we need a fix in the next few weeks before that upgrade can happen.
👩💻 Implementation
Use JavaScript to measure textarea's scrollHeight, compute 6-line max from resolved line-height and add padding to set the text area's inline height on when the user is adding text/resizing the text area.
Once content exceeds that max height, the logic switches the textarea to overflowY = 'auto'; otherwise it keeps overflowY = 'hidden', and it separately recalculates scrollbar width so the error icon placement stays correct when a vertical scrollbar appears.
🧪 Testing
✅ Checklist