support mmap as source for package #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on suggestion from @qkaiser. This will make it easier to integrate with unblob (see onekey-sec/unblob#1244).
for more information, see https://pre-commit.ci
Should probably think of a better test...
jcrussell
added a commit
to jcrussell/unblob
that referenced
this pull request
Sep 3, 2025
Requires this PR to (almost) work properly: nightlark/pymsi#81
jcrussell
changed the title
nightlark
reviewed
Sep 18, 2025
| self.path = None | ||
| self.file = path_or_bytesio | ||
| else: | ||
| # TODO: consider typing.BinaryIO |
There was a problem hiding this comment.
Interesting discussion typing.*IO: python/typing#829
Leaning towards the current list of type options being fine for now, with the option to change it later if needed for e.g. integration with unblob.
nightlark
reviewed
Sep 18, 2025
|
|
||
| size = (msi.package.ole.nb_sect * msi.package.ole.sector_size) + 512 | ||
|
|
||
| print(size) |
There was a problem hiding this comment.
I guess it would probably be good to pick a specific version of powertoys.msi eventually so that we know what size to expect here. (Doesn't need to be part of this PR though)
|
@nightlark: thoughts about merging this? |
nightlark
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on suggestion from @qkaiser. This will make it easier to integrate with unblob (see onekey-sec/unblob#1244).
Proposed changes
Add mmap as possible input to
Packageand add test cases.I marked it as WIP to see if it makes sense to use
typing.BinaryIOas the type hint (which sounds like it might work from its description). I also left a TODO for actually testing something about the parsed MSI (I didn't havepowertoys.msiso I just used7z).