Skip to content

Conversation

@reallymello
Copy link
Contributor

@reallymello reallymello commented Mar 1, 2025

Addresses reported issue #4382

This updates dependencies in mocha, cucumber, and lint-staged to address CVEs detected by npm audit. Versions used are not strictly backward compatible, but when the tests were rerun after the changes no new failures occurred. The only test failing was a strictly equal check should load es6 module and that was failing before the changes as well.

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Before marking your PR for review, please test and verify your changes by making appropriate modifications to any of the Nightwatch example tests (present in examples/tests directory of the project) and running them. ecosia.js and duckDuckGo.js are good examples to work with.
  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@github-actions
Copy link

github-actions bot commented Mar 1, 2025

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@reallymello
Copy link
Contributor Author

Failing tests in the Node v16 pipeline appear related to structuredClone not being added to the Node framework until version 17 of node and it appears the newer dependencies reference it. Does Nightwatch need to support Node 16 still? Node 16 went end of life September 2023.

@ecfaria
Copy link

ecfaria commented Aug 25, 2025

@beatfactor Is there any timeline for merging this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants