Second capture issue and blackout boxes positioning#32
Open
lucianmldvn wants to merge 5 commits intoniklasvh:masterfrom
Open
Second capture issue and blackout boxes positioning#32lucianmldvn wants to merge 5 commits intoniklasvh:masterfrom
lucianmldvn wants to merge 5 commits intoniklasvh:masterfrom
Conversation
If you try to make another screen shot after you already made one, the script will always capture the first screen shot you made. I consider this a bug. Please update feedback.js to no use the cached screen shot. Thank you.
added 3 commits
October 8, 2014 09:41
Black boxes were positioned incorrectly after screen capture on a page with scroll, this commit fixes it.
This reverts commit 70febaf.
Black boxes were positioned incorrectly after screen capture on a page with scroll, this commit fixes it.
lucianmldvn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you try to make another screen shot after you already made one, the script will always capture the first screen shot you made. I consider this a bug.
Please update feedback.js to no use the cached screen shot.
Thank you.