MNT: Add flake8-logging-format (G) rules to ruff

[DimitriPapadopoulos]

Changes proposed in this pull request

ruff check --select G

Documentation that should be reviewed

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 73.50%. Comparing base (5bb1cf5) to head (feeec8f).
⚠️ Report is 93 commits behind head on master.

Files with missing lines	Patch %	Lines
fmriprep/_warnings.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3242   +/-   ##
=======================================
  Coverage   73.50%   73.50%           
=======================================
  Files          60       60           
  Lines        4582     4582           
  Branches      585      585           
=======================================
  Hits         3368     3368           
  Misses       1085     1085           
  Partials      129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[effigies]

I'm not sure why we should care about this.

[DimitriPapadopoulos]

The linter recommends that because that's what many programmers suggest: defer string interpolation to the log function so that string interpolation doesn't occur whenever the log function doesn't print at the current log level. So that would be a performance issue. The rationale is that the speed gain when deferring string interpolation with terse logging outwheighs the speed gain of f-strings with verbose logging. Other programmers don't agree.

[effigies]

We decided in #3515 to generally prefer f-strings. Thanks for the effort, but we won't be enabling this rule and I'm closing this.

[DimitriPapadopoulos]

That's not really about- f-strings.

Just to make sure, this is not about using

logger.info("info: %s" % s)

vs.

logger.info(f"info: {s}")

It's about

logger.info("info: %s", s)

[effigies]

Correct.