Skip to content

Conversation

jhlegarreta
Copy link
Contributor

@jhlegarreta jhlegarreta commented Aug 20, 2025

Changes proposed in this pull request

Fix non-standard Input/Output docstring section management: map Inputs and Outputs to params_style and returns_style, respectively, for napoleon custom sections (instead of mapping them to Parameters).

Documentation:
https://www.sphinx-doc.org/en/master/usage/extensions/napoleon.html#confval-napoleon_custom_sections

Documentation that should be reviewed

Any workflow function.

@jhlegarreta
Copy link
Contributor Author

Have not tested locally.

jhlegarreta added a commit to jhlegarreta/fmriprep that referenced this pull request Aug 20, 2025
Add myself to contributor list after:
nipreps#3504
nipreps#3505
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.56%. Comparing base (03e209f) to head (eebd67b).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3505   +/-   ##
=======================================
  Coverage   73.56%   73.56%           
=======================================
  Files          60       60           
  Lines        4600     4600           
  Branches      585      585           
=======================================
  Hits         3384     3384           
- Misses       1087     1089    +2     
+ Partials      129      127    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Fix non-standard Input/Output docstring section management: map
`Inputs` and `Outputs` to `params_style` and `returns_style`,
respectively, for `napoleon` custom sections (instead of mapping them
to `Parameters`).

Documentation:
https://www.sphinx-doc.org/en/master/usage/extensions/napoleon.html#confval-napoleon_custom_sections
@jhlegarreta jhlegarreta force-pushed the doc/fix-io-section-treatment branch from bb65399 to eebd67b Compare August 21, 2025 22:09
@jhlegarreta
Copy link
Contributor Author

Same fix applied to PETPrep: nipreps/petprep#105

@jhlegarreta jhlegarreta requested a review from effigies August 27, 2025 13:21
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Latest

image

This PR

image

@effigies effigies merged commit bef209a into nipreps:master Aug 27, 2025
21 checks passed
@jhlegarreta jhlegarreta deleted the doc/fix-io-section-treatment branch August 27, 2025 22:48
effigies added a commit that referenced this pull request Aug 29, 2025
## Changes proposed in this pull request

Add myself to contributor list after:
#3504
#3505

## Documentation that should be reviewed

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants