-
Notifications
You must be signed in to change notification settings - Fork 18
FIX: Ordering of ITK displacements fields when reading and writing #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
e4e2b0a
to
076c4fa
Compare
@feilong apologies for the noise of the force-pushes |
Transposes data as suggested by @feilong when reading and writing displacements fields. Tests have been added to ensure round-trip consistency. Related-to: #171. Co-Authored-By: Feilong Ma <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 95.09% 0.00% -95.10%
==========================================
Files 16 16
Lines 1979 1984 +5
Branches 265 0 -265
==========================================
- Hits 1882 0 -1882
- Misses 77 1984 +1907
+ Partials 20 0 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@oesteban No worries. Happy to see the issue fixed in nitransforms. |
Resolves: #267.
961a020
to
b807020
Compare
It doesn't look this transposition is the right answer (pictures extracted within the |
b807020
to
eee5a4e
Compare
Transposes data as suggested by @feilong when reading and writing ITK displacements fields.
Tests have been added to ensure round-trip consistency.
Related-to: #171.