add withDesktopFile option and use nvchad.desktop instead of nvim.des…

[aguirre-matteo]

This pull request adds an option for making it possible to opt-out of the .desktop file the package provides. I also made it use Nvchad's logo and print "Nvchad" instead of "Neovim by Nvchad", since that makes more sense to me.

[MOIS3Y]

As far as I remember, when I was still making the prototype, during the discussion we came to the conclusion that NvChad is not a program, but a configuration. To avoid confusion, we decided to substitute nvim.
I'm not sure the withDesktopFile option adds enough value to justify its inclusion.

[aguirre-matteo]

IMO users should have the option to opt-out of the desktop entry in their app launchers, since in most cases we launch nvim from the terminal, and having that entry is bit annoying (in my case, for instance, trying to launch nvim from the desktop entry simply doesn't work).

[MOIS3Y]

By default, nvim also provides a .desktop file; this simply replicates that behavior.
This file will be located in /etc/profiles/per-user/username/share/applications/nvim.desktop

TryExec=nvim
Exec=nvim %F
Terminal=true
Type=Application

These lines ensure it launches in your default terminal.
I just checked on my system, and it opens nvim.

I can't understand what the irritation is about.

[MOIS3Y]

Sorry, but this option seems redundant to me.
Moreover, it affects the current package build (NvChad.desktop, nvchad.svg).
Probably, these should be removed from the repository altogether. I think I only left the SVG file because I spent some time creating it 😅

Initially, I never planned to add options like:

• extraConfig
• lazy-lock
• chadrcConfig

Because they seem redundant.
And I would still advocate for a minimalist approach.
The author of NvChad tends to make backward-incompatible design changes, which in the future with many options will make derivative maintenance unbearable.

In my opinion, the most correct way to add your own configuration remains adding it via pure lua as a flake input.

@Bot-wxt1221 what do you think?