Skip to content

Add support for IP_MTU_DISCOVER to sockopt #2652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions src/sys/socket/sockopt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1574,6 +1574,85 @@ impl SetSockOpt for FilterDetach {
}
}
}

#[cfg(any(linux_android, target_os = "cygwin"))]
#[derive(Copy, Clone, Debug, PartialEq, Eq)]
/// "Path MTU Discovery" setting for an IPv4/IPv6 socket.
pub enum IpMtuDiscover {
/// Never do Path MTU Discovery.
Dont,
/// Use per-route settings.
Want,
/// Always do Path MTU Discovery.
Do,
/// Set DF but ignore Path MTU.
Probe,
#[cfg(linux_android)]
/// Always use interface MTU (ignores dst PMTU) but don't set DF flag.
/// Also incoming ICMP frag_needed notifications will be ignored on
/// this socket to prevent accepting spoofed ones.
Interface,
#[cfg(linux_android)]
/// Weaker version of `Interface`, which allows packets to get
/// fragmented if they exceed the interface MTU.
Omit,
}

#[cfg(any(linux_android, target_os = "cygwin"))]
impl From<IpMtuDiscover> for c_int {
fn from(value: IpMtuDiscover) -> Self {
match value {
IpMtuDiscover::Dont => libc::IP_PMTUDISC_DONT,
IpMtuDiscover::Want => libc::IP_PMTUDISC_WANT,
IpMtuDiscover::Do => libc::IP_PMTUDISC_DO,
IpMtuDiscover::Probe => libc::IP_PMTUDISC_PROBE,
#[cfg(linux_android)]
IpMtuDiscover::Interface => libc::IP_PMTUDISC_INTERFACE,
#[cfg(linux_android)]
IpMtuDiscover::Omit => libc::IP_PMTUDISC_OMIT,
}
}
}

#[cfg(any(linux_android, target_os = "cygwin"))]
impl TryFrom<c_int> for IpMtuDiscover {
type Error = ();

fn try_from(value: c_int) -> std::result::Result<Self, Self::Error> {
match value {
libc::IP_PMTUDISC_DONT => Ok(IpMtuDiscover::Dont),
libc::IP_PMTUDISC_WANT => Ok(IpMtuDiscover::Want),
libc::IP_PMTUDISC_DO => Ok(IpMtuDiscover::Do),
libc::IP_PMTUDISC_PROBE => Ok(IpMtuDiscover::Probe),
#[cfg(linux_android)]
libc::IP_PMTUDISC_INTERFACE => Ok(IpMtuDiscover::Interface),
#[cfg(linux_android)]
libc::IP_PMTUDISC_OMIT => Ok(IpMtuDiscover::Omit),
_ => Err(()),
}
}
}

#[cfg(any(linux_android, target_os = "cygwin"))]
sockopt_impl!(
/// Set or get the "Path MTU Discovery" setting for an IPv4 socket.
Ipv4MtuDiscover,
Both,
libc::IPPROTO_IP,
libc::IP_MTU_DISCOVER,
IpMtuDiscover
);

#[cfg(any(linux_android, target_os = "cygwin"))]
sockopt_impl!(
/// Set or get the "Path MTU Discovery" setting for an IPv6 socket.
Ipv6MtuDiscover,
Both,
libc::IPPROTO_IPV6,
libc::IP_MTU_DISCOVER,
IpMtuDiscover
);

/*
*
* ===== Accessor helpers =====
Expand Down
31 changes: 31 additions & 0 deletions test/sys/test_sockopt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1270,3 +1270,34 @@ pub fn test_so_attach_reuseport_cbpf() {
assert_eq!(e, nix::errno::Errno::ENOPROTOOPT);
});
}

#[cfg(any(linux_android, target_os = "cygwin"))]
#[test]
pub fn test_set_get_ip_mtu_discover() {
use sockopt::{IpMtuDiscover, Ipv4MtuDiscover};

let values = [
IpMtuDiscover::Dont,
IpMtuDiscover::Want,
IpMtuDiscover::Do,
IpMtuDiscover::Probe,
#[cfg(linux_android)]
IpMtuDiscover::Interface,
#[cfg(linux_android)]
IpMtuDiscover::Omit,
];

let fd = socket(
AddressFamily::Inet,
SockType::Datagram,
SockFlag::empty(),
None,
)
.unwrap();

for value in values {
setsockopt(&fd, Ipv4MtuDiscover, &value).unwrap();
let v = getsockopt(&fd, Ipv4MtuDiscover).unwrap();
assert_eq!(v, value);
}
}
Loading