Open
Conversation
Replace .unwrap() with .unwrap_or(BaudRate::B0) to gracefully handle conversion errors on glibc 2.42+. Fixes nix-rust#2672 and uutils/coreutils#8474. - src/sys/termios.rs: cfgetospeed() and cfgetispeed() - test/sys/test_termios.rs: 4 new integration tests
naoNao89
force-pushed
the
fix/glibc-2.42-termios
branch
from
f75f8ef to
172e1d9
Compare
|
Is there natural |
|
Do we have any documentation on that fallback pattern being the default that we can add to this PR? |
|
I think we should have an error instead fallbacking to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stty panics on Ubuntu 25.10 (glibc 2.42) with EINVAL in cfgetospeed/cfgetispeed.
Solution: Replace .unwrap() -> .unwrap_or(BaudRate::B0) to handle conversion errors gracefully.
Fixes #2672, uutils/coreutils#8474