ioctl: add support for cygwin

[500-internal-server-error]

What does this PR do

Enable ioctl support for Cygwin, based on the Cygwin C headers

Checklist:

• I have read CONTRIBUTING.md
• I have written necessary tests and rustdoc comments
• A change log has been added if this PR modifies nix's API

[500-internal-server-error]

I was going to unpin and update libc because it is needed for downstream projects, but it seems to need a pending fix in libc. Will wait for it before trying again.

[500-internal-server-error]

Cleaning up commits.

[500-internal-server-error]

Seems like most platforms compile fine, it's libc itself that's failing to build for those platforms?

[oech3]

#2715 (comment)

@tgross35 Similar missing issue like rust-lang/libc#4913 ?

[tgross35]

NetBSD: the target was pretty broken, we used that as an opportunity to do some minor breakage in https://github.com/rust-lang/libc/releases/tag/0.2.178. The special casing here will need to be removed

nix/src/sys/event.rs

Lines 94 to 97 in ba63e90

	#[cfg(any(freebsdlike, apple_targets, target_os = "openbsd"))]
	type type_of_udata = *mut libc::c_void;
	#[cfg(target_os = "netbsd")]
	type type_of_udata = intptr_t;

and #2709 for IFF_NOTRAILERS.

uclibc: Looks like this was unintentional from rust-lang/libc@2fe1d91.

[500-internal-server-error]

Maybe the libc fixes should be split off into a different PR? Or combined into #2709?

Anyways, cleaned up commits for now.

[oech3]

Does not this repo have bot for crate bump?

[tgross35]

For uclibc, rust-lang/libc@3dad489 and rust-lang/libc@e0ed72d. I'll cut a new release tomorrowish.

[500-internal-server-error]

I'll cut a new release tomorrowish.

No 0.2 backport?

[tgross35]

What do you mean?

[oech3]

I think backport means 0.2.180 (no major bump). Sorry for triggering too many release (stty, musl ,etc...

[tgross35]

I don't usually do the backports until just before I release. I have it cooking locally but just haven't had a chance to wrap it up yet.

Sorry for triggering too many release (stty, musl ,etc...

Certainly nobody's fault 🙂 the past two releases have been ~10kloc which is way higher than the average of around 1-3k, so there were some things that snuck in.

I'll ping on this thread when the release is out.

[tgross35]

It's out https://github.com/rust-lang/libc/releases/tag/0.2.180

[oech3]

conflicting

[500-internal-server-error]

conflicting

Rebased.

[oech3]

@SteveLauC Would you review this?

[oech3]

still difficult to merge?

[500-internal-server-error]

@SteveLauC Could you review and merge?

[oech3]

@SteveLauC ping?

[oech3]

Can we bypass this change at downstream(uutils) by manualy declaring them?

[500-internal-server-error]

Can we bypass this change at downstream(uutils) by manualy declaring them?

Probably, MSYS2 already uses this PR as a .patch.

[oech3]

I'm considering to add CI to uutils's repo, but a patch section in Cargo.toml for crates is bit complex.

[500-internal-server-error]

Maybe just reuse MSYS2 CI? PKGBUILDs are just shell scripts after all.

[SteveLauC]

Thanks