Skip to content

unistd: remove fork/exec on fuchsia#2729

Draft
xtqqczze wants to merge 1 commit intonix-rust:masterfrom
xtqqczze:unistd-fuchsia
Draft

unistd: remove fork/exec on fuchsia#2729
xtqqczze wants to merge 1 commit intonix-rust:masterfrom
xtqqczze:unistd-fuchsia

Conversation

@xtqqczze
Copy link
Contributor Author

Hmm, it’s surprising that the test_wait_signal test would have previously passed if fork always returned an Err on Fuchsia:

error[E0425]: cannot find function `fork` in this scope
  --> test/sys/test_wait.rs:15:20
   |
15 |     match unsafe { fork() }.expect("Error: Fork Failed") {
   |                    ^^^^ not found in this scope
   |

@stepancheg
Copy link

Even if functions are unimplemented, it is often convenient to have them, so you don't have to turn your project into endless cfg-guards.

In fact, this is likely the reason why these function are declared in fuchsia, to make writing cross-platform code easier.

(I have very little to do with this project, so this is my 2 cents.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants