unistd: remove fork/exec on fuchsia#2729
Draft
xtqqczze wants to merge 1 commit intonix-rust:masterfrom
Draft
Conversation
On Fuchsia, these functions fail with errno `ENOSYS` by design. References: - https://fuchsia.dev/fuchsia-src/development/languages/c-cpp/libc#posix - https://cs.opensource.google/fuchsia/fuchsia/+/main:zircon/third_party/ulib/musl/src/process/fork.c
8830a31 to
f0d0f00
Compare
Contributor
Author
|
Hmm, it’s surprising that the |
|
Even if functions are unimplemented, it is often convenient to have them, so you don't have to turn your project into endless cfg-guards. In fact, this is likely the reason why these function are declared in fuchsia, to make writing cross-platform code easier. (I have very little to do with this project, so this is my 2 cents.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Fuchsia, these functions are intentionally unimplemented and return
ENOSYS.References: