Skip to content

unistd: add mkfifo for redox#2749

Merged
SteveLauC merged 1 commit intonix-rust:masterfrom
cakebaker:remove_mkfifo_gate
Mar 16, 2026
Merged

unistd: add mkfifo for redox#2749
SteveLauC merged 1 commit intonix-rust:masterfrom
cakebaker:remove_mkfifo_gate

Conversation

@cakebaker
Copy link
Contributor

What does this PR do

This PR removes the #[cfg(not(target_os = "redox"))] gate as I think it is no longer necessary. Over in uutils/coreutils we also use libc::mkfifo and it compiles on redox in our CI.

@xtqqczze

This comment was marked as outdated.

@cakebaker cakebaker marked this pull request as draft March 9, 2026 15:10
@cakebaker cakebaker marked this pull request as ready for review March 9, 2026 15:33
@cakebaker
Copy link
Contributor Author

@xtqqczze thanks, that did the trick.

@xtqqczze

This comment was marked as outdated.

@xtqqczze

This comment was marked as outdated.

@oech3
Copy link

oech3 commented Mar 16, 2026

conflicts

@cakebaker cakebaker force-pushed the remove_mkfifo_gate branch from 5273844 to f5024a6 Compare March 16, 2026 08:22
@cakebaker
Copy link
Contributor Author

@oech3 thanks for the hint!

@SteveLauC SteveLauC changed the title unistd: remove gate from mkfifo unistd: add mkfifo for redox Mar 16, 2026
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@SteveLauC SteveLauC added this pull request to the merge queue Mar 16, 2026
Merged via the queue into nix-rust:master with commit 8dff4e7 Mar 16, 2026
59 of 61 checks passed
@cakebaker cakebaker deleted the remove_mkfifo_gate branch March 16, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants