-
Notifications
You must be signed in to change notification settings - Fork 2
Rails 4! Ruby 2.0! #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
.rbenv-version
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename this file to .ruby-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look deprecated to me: http://edgeapi.rubyonrails.org/classes/ActionView/Helpers/AssetTagHelper.html#method-i-image_tag
What happens when you use it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UndefinedMethod image_tag for <Class:…>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, use image_path rather than asset_path if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k
Excuse this gross commit message.
Gemfile.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do a bundle update jazz_hands. I released a Rails 4 compatible version today. It should end up with 0.5.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and its Done.
|
👍 |
border-radius)protected_attributesgem for Rails 3 style param security till we migrate.ActiveModel::Namechange.asset_pathinstead ofimage_tagin ERB'd sass/coffee files, as the latter seems to be deprecated.matchis no longer supported withoutvia:[*methods])whiny_nils,auto_explain_threshold)schema.rbTODO
border-radius,text-shadow)routes.rbfile changes match expectations (@nixme)