Skip to content

Conversation

@arbales
Copy link
Collaborator

@arbales arbales commented Mar 8, 2013

  • Added shims for deprecated sass helpers (like border-radius)
  • Added protected_attributes gem for Rails 3 style param security till we migrate.
  • Upgraded Tire to support Rails 4's ActiveModel::Name change.
  • Use a Rails 4-supporting fork of SWFObject
  • Use asset_path instead of image_tag in ERB'd sass/coffee files, as the latter seems to be deprecated.
  • Update routes syntax (match is no longer supported without via:[*methods])
  • Removed configuration options no longer supported in Rails 4 (whiny_nils, auto_explain_threshold)
  • Use modern hash syntax in schema.rb

TODO

  • Move to new param protection
  • Remove references to deprecated vendor-prefix mixins (border-radius, text-shadow)
  • Ensure routes.rb file changes match expectations (@nixme)
  • Apologize to @nixme for my Gemfile.lock mutilation

.rbenv-version Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this file to .ruby-version

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UndefinedMethod image_tag for <Class:…>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, use image_path rather than asset_path if possible.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k

Gemfile.lock Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do a bundle update jazz_hands. I released a Rails 4 compatible version today. It should end up with 0.5.0

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and its Done.

@nixme
Copy link
Owner

nixme commented Mar 8, 2013

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants