Skip to content

Conversation

@jurgenbelien
Copy link
Contributor

Closes #318

  • Aantal prettier issues
  • Combobox options hoeven geen expliciet label te hebben (options=${['a','b','c']})
  • Combobox mag een DOMTokenList zijn (options="a b c")

@vercel
Copy link

vercel bot commented Jan 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
clippy-storybook Ready Ready Preview, Comment Jan 19, 2026 3:33pm
theme-wizard Ready Ready Preview Jan 19, 2026 3:33pm
theme-wizard-server Ready Ready Preview, Comment Jan 19, 2026 3:33pm

Request Review

@jurgenbelien jurgenbelien force-pushed the feat/combobox-tokenlist branch from 5bd8cf0 to 393a2a6 Compare January 19, 2026 15:32
@sonarqubecloud
Copy link

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 90.00000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.44%. Comparing base (c454e47) to head (393a2a6).
⚠️ Report is 166 commits behind head on main.

Files with missing lines Patch % Lines
...kages/clippy-components/src/lib/FormField/index.ts 80.76% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #447      +/-   ##
===========================================
- Coverage   100.00%   90.44%   -9.56%     
===========================================
  Files           12       49      +37     
  Lines          694     1402     +708     
  Branches       100      301     +201     
===========================================
+ Hits           694     1268     +574     
- Misses           0      110     +110     
- Partials         0       24      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jurgenbelien jurgenbelien marked this pull request as ready for review January 20, 2026 08:04
@jurgenbelien jurgenbelien requested a review from a team as a code owner January 20, 2026 08:04
@jurgenbelien jurgenbelien merged commit 8331d96 into main Jan 20, 2026
11 checks passed
@jurgenbelien jurgenbelien deleted the feat/combobox-tokenlist branch January 20, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combobox accepteert tokenlist als options

5 participants