Skip to content

fix: accept combobox values immediately on blur instead of after pres…#643

Merged
bartveneman merged 11 commits intomainfrom
fix/accept-value-on-blur
Mar 27, 2026
Merged

fix: accept combobox values immediately on blur instead of after pres…#643
bartveneman merged 11 commits intomainfrom
fix/accept-value-on-blur

Conversation

@bartveneman
Copy link
Copy Markdown
Contributor

@bartveneman bartveneman commented Mar 27, 2026

…sing Enter

Before:

Screen.Recording.2026-03-27.at.10.35.46.mov

After:

Screen.Recording.2026-03-27.at.10.46.45.mov
Screenshot 2026-03-27 at 11 53 16 Screenshot 2026-03-27 at 11 54 30

Other notable changes:

  • reduce code duplication in combobox logic (with passing tests)
  • fix font-size preview in combobox when entering value manually (& tests)
  • show hover state for combobox options

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clippy-storybook Ready Ready Preview Mar 27, 2026 3:11pm
theme-wizard Ready Ready Preview Mar 27, 2026 3:11pm
theme-wizard-server Ready Ready Preview Mar 27, 2026 3:11pm

Request Review

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.61%. Comparing base (573f4a2) to head (645accc).
⚠️ Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
...pp/src/components/wizard-colorscale-input/index.ts 62.50% 3 Missing ⚠️
...ippy-components/src/clippy-color-combobox/index.ts 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
- Coverage   88.06%   84.61%   -3.46%     
==========================================
  Files          57       69      +12     
  Lines        1701     2119     +418     
  Branches      378      488     +110     
==========================================
+ Hits         1498     1793     +295     
- Misses        166      270     +104     
- Partials       37       56      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ermenm
ermenm previously approved these changes Mar 27, 2026
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants