Skip to content

Conversation

@mattfidler
Copy link
Member

Closes #208

When filtering based on NONMEM input information, sometimes the data
frame is still character values instead of numeric values.

This pull request should fix that.

@mattfidler mattfidler requested a review from Copilot October 16, 2025 20:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #208 by ensuring that imported NONMEM data is converted to numeric types when appropriate. The problem occurred when filtering based on NONMEM input information resulted in character values instead of numeric values.

Key Changes:

  • Added numeric conversion logic to handle character data that represents numeric values
  • Implemented comprehensive NA/missing value handling during conversion
  • Added test coverage for the numeric import functionality

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
R/readInNonmemInput.R Core fix: Added conversion loop to transform character columns to numeric when possible, with special handling for various NA representations
tests/testthat/test-import-numeric.R Added test case to verify numeric import with data filtering using IGNORE clauses
NEWS.md Documented the fix for issue #208
DESCRIPTION Bumped version to development version 0.1.8.9000

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mattfidler mattfidler merged commit 40d5bfc into main Oct 16, 2025
10 of 11 checks passed
@mattfidler mattfidler deleted the 208-data-import branch October 16, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error : event id ('evid') needs to be an integer

2 participants