Skip to content

Fix missing exports from json.cppm#5137

Open
mikomikotaishi wants to merge 1 commit intonlohmann:developfrom
mikomikotaishi:patch-1
Open

Fix missing exports from json.cppm#5137
mikomikotaishi wants to merge 1 commit intonlohmann:developfrom
mikomikotaishi:patch-1

Conversation

@mikomikotaishi
Copy link
Copy Markdown
Contributor

@mikomikotaishi mikomikotaishi commented Apr 15, 2026

[Describe your pull request here. Please read the text below the line and make sure you follow the checklist.]

This pull request restores some missing symbols that were present in the <nlohmann/json.hpp> header, but weren't exported in json.cppm. These include specialisations in namespace std (such as hash<> and less<>), as well as nlohmann::literals::json_literals::*. This is necessary as without this those specialisations and symbols are inaccessible from the module.

  • The changes are described in detail, both the what and why.
  • If applicable, an existing issue is referenced.
  • The Code coverage remained at 100%. A test case for every new line of code.
  • If applicable, the documentation is updated.
  • The source code is amalgamated by running make amalgamate.

Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com>
@github-actions github-actions bot added the M label Apr 15, 2026
@mikomikotaishi
Copy link
Copy Markdown
Contributor Author

mikomikotaishi commented Apr 15, 2026

Also, if someone could clarify or give more explanation on why the tests are failing it would be appreciated. I'm not sure why my changes would cause a test to fail as no code is changed.

In either case the modules test pass, and the only file edited is the module file itself, so I don't think whatever is failing was caused by this edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant