Fix missing exports from json.cppm#5137
Open
mikomikotaishi wants to merge 1 commit intonlohmann:developfrom
Open
Fix missing exports from json.cppm#5137mikomikotaishi wants to merge 1 commit intonlohmann:developfrom
json.cppm#5137mikomikotaishi wants to merge 1 commit intonlohmann:developfrom
Conversation
Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com>
Contributor
Author
|
Also, if someone could clarify or give more explanation on why the tests are failing it would be appreciated. I'm not sure why my changes would cause a test to fail as no code is changed. In either case the modules test pass, and the only file edited is the module file itself, so I don't think whatever is failing was caused by this edit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Describe your pull request here. Please read the text below the line and make sure you follow the checklist.]
This pull request restores some missing symbols that were present in the
<nlohmann/json.hpp>header, but weren't exported injson.cppm. These include specialisations in namespacestd(such ashash<>andless<>), as well asnlohmann::literals::json_literals::*. This is necessary as without this those specialisations and symbols are inaccessible from the module.make amalgamate.