Fix/refresh hotreload rebuild fixes#158
Open
mwahnish wants to merge 4 commits into
Open
Conversation
…Every hot reload would spawn another pthread, until an out of memory exception occurred.
…s called when native assets have been freed but FilamentApp.instance is not null a crash occurs. Nulling the instance prior to destroying the render thread prevents this race condition
…oads). This can cause the app to freeze. This fix automatically polls the queue so we are not reliant on the runtime.
…ular, there was a crash that could happen when the Thermion Widget was rebuilt
Owner
|
Unfortunately I didn't get a chance to look at this last week, and this week is looking equally busy. As soon as I get a chance I'll come back to review. |
Contributor
Author
|
No problem at all, take your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A series of fixes aiming to improve how Thermion handles widget rebuilds and hot reloads, and restarts