Skip to content

mobile: synthesised tap uses localFocalPoint, not focalPoint (follow-up to #163) #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mushogenshin wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

mobile: synthesised tap uses localFocalPoint, not focalPoint (follow-up to #163) #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions thermion_flutter/thermion_flutter/lib/src/widgets/src/thermion_listener_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,16 @@ class _MobileListenerWidgetState extends State<_MobileListenerWidget> {
(_EagerScaleGestureRecognizer instance) {
instance
..onStart = (ScaleStartDetails event) {
_scaleStartFocal = event.focalPoint;
// Capture the *local* focal point (widget-relative) for
// tap synthesis. The synthesised tap dispatches via
// TouchEvent.localPosition, which is what
// `View.pick(x, y, ...)` consumes — pick wants viewport-
// relative pixels, not screen-global. Using
// `event.focalPoint` (global) here was wrong: picks
// landed outside the rendered viewport whenever the
// widget wasn't at (0,0) on the screen, which is
// basically every real layout.
_scaleStartFocal = event.localFocalPoint;
_scaleStartTime = DateTime.now();
_scaleMaxMovement = 0;
widget.inputHandler.handle(ScaleStartEvent(
Expand All @@ -360,8 +369,12 @@ class _MobileListenerWidgetState extends State<_MobileListenerWidget> {
}
..onUpdate = (ScaleUpdateDetails event) {
if (_scaleStartFocal != null) {
// Compare local-to-local for the tap-vs-drag movement
// threshold. Mixing global with local would inflate
// the distance by the widget's screen position and
// misclassify static taps as drags.
final movement =
(event.focalPoint - _scaleStartFocal!).distance;
(event.localFocalPoint - _scaleStartFocal!).distance;
if (movement > _scaleMaxMovement) {
_scaleMaxMovement = movement;
}
Expand Down
Loading